Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(concept): allow to collapse concepts sections #144

Merged

Conversation

assuncaocharles
Copy link
Contributor

This PR allows to collapse sections from concepts page

O90E3zQYqa

@gregwhitworth
Copy link
Member

@assuncaocharles thank you so much for taking the time to do this. Can you make it so that they are hidden by default or have a collapse/expand all as well?

@assuncaocharles
Copy link
Contributor Author

Hey @gregwhitworth

added option to expand/collapse all:

NTkIAQ7aRO

@assuncaocharles
Copy link
Contributor Author

Does it work for you @gregwhitworth ?

@gregwhitworth
Copy link
Member

gregwhitworth commented Aug 3, 2020 via email

@gregwhitworth
Copy link
Member

gregwhitworth commented Aug 4, 2020

@assuncaocharles ok, so now I can expand/collapse them all but I'd expect to be able to collapse them all and then upon click of a single title it would expand that one. Currently the only way to see one I have to expand all of them.

And again - thanks for the help on this.

@assuncaocharles
Copy link
Contributor Author

assuncaocharles commented Aug 4, 2020

@assuncaocharles ok, so now I can expand/collapse them all but I'd expect to be able to collapse them all and then upon click of a single title it would expand that one. Currently the only way to see one I have to expand all of them.

And again - thanks for the help on this.

Hey @gregwhitworth

Good catch, fixed. I guess we are good to go now :)

@gregwhitworth gregwhitworth merged commit 0861a18 into openui:master Aug 11, 2020
@assuncaocharles assuncaocharles deleted the feat/collapsable-concepts branch August 11, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concepts component should collapse and expand the examples
2 participants