Adding double quotes around the NugetExe and $WorkingFolder variables #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuget will not work if the target path has spaces in it without double quotes.
making change to kick off pr build
Another minor change to trigger build
|
Nicely done! Got pr running off your forked project. It failed on some strangeness but kicked off again from VSTS and all good. Once it's merged I'll write a test around your change. |
|
Cool. That was a strange one, but it worked up until the point that it tried to drop the dac stuff into a _really_ long path with lots of spaces. 😊
…-Peter
________________________________
From: Richie Lee <notifications@github.com>
Sent: Tuesday, October 2, 2018 3:50 PM
To: RichieBzzzt/PoshSSDTBuildDeploy
Cc: Peter Schott; Author
Subject: Re: [RichieBzzzt/PoshSSDTBuildDeploy] Adding double quotes around the NugetExe and $WorkingFolder variables (#40)
Nicely done!
Got pr running off your forked project. It failed on some strangeness but kicked off again from VSTS and all good. Once it's merged I'll write a test around your change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRichieBzzzt%2FPoshSSDTBuildDeploy%2Fpull%2F40%23issuecomment-426425476&data=02%7C01%7C%7C2e86e49bae04497830bd08d628a8c0b3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636741102575439083&sdata=YmlDsY5Jb4fCB5eyibDe%2BhWz016d9ORV1QfUyNnCvJc%3D&reserved=0>, or mute the thread<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAU0dxiwpGQJwiI3eIJboqekkx9Aro1Xks5ug9GwgaJpZM4XEzHf&data=02%7C01%7C%7C2e86e49bae04497830bd08d628a8c0b3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636741102575439083&sdata=LMzqJwio5Mf5nHVBsepxNSUl3sndljN3xqsjKDg%2FvQ8%3D&reserved=0>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuget will not work if the target path has spaces in it without double quotes.